Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rust] Support for multiple browser names in Selenium Manager (#11352) #11420

Merged
merged 2 commits into from
Dec 13, 2022
Merged

[rust] Support for multiple browser names in Selenium Manager (#11352) #11420

merged 2 commits into from
Dec 13, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR allows to use different browser names in Selenium Manager:

  • "ie", "InternetExplorer", "internet-explorer", "internet_explorer" (in addition to "iexplorer") for Internet Explorer.
  • "msedge", "MicrosoftEdge" (in addition to "edge") for Edge.

Motivation and Context

This PR implements #11352.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol
diemol approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a one off, but if we keep doing this it'd be nice to have a list of browser names to check and a shorter if.

But it does look good to me.

@bonigarcia
Copy link
Member Author

@diemol No problem, I just committed a second patch using a vector in the conditional.

@bonigarcia bonigarcia merged commit 8467a8c into trunk Dec 13, 2022
@bonigarcia bonigarcia deleted the se_mgr_multiple_browser_names branch December 13, 2022 16:03
@bonigarcia bonigarcia mentioned this pull request Dec 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bonigarcia @diemol