Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Selenium Manager support browserName recognized by each driver #11352

Closed
titusfortner opened this issue Dec 2, 2022 · 6 comments

Comments

@titusfortner
Copy link
Member

Feature and motivation

Right now --browser only supports iexplorer and it seems like it should be easy to support both. All of the Selenium code right now is either "IE" or "InternetExplorer". I had to hack a workaround in Python code, (though hopefully we change this soon anyway).

Usage example

selenium-manager --browser ie
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

@titusfortner, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@diemol
Copy link
Member

diemol commented Dec 3, 2022

👍 this makes sense

@titusfortner
Copy link
Member Author

So, looking at actual implementations, what we really want is "internet explorer" here (https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/remote/Browser.java#L41)

and for that matter MicrosoftEdge: https://github.com/SeleniumHQ/selenium/blob/trunk/java/src/org/openqa/selenium/remote/Browser.java#L32

I'm guessing we can't have spaces on command line, so maybe internet-explorer or internet_explorer?

@titusfortner titusfortner changed the title [🚀 Feature]: Selenium Manager support "ie" [🚀 Feature]: Selenium Manager support "internet-explorer" Dec 7, 2022
@titusfortner titusfortner changed the title [🚀 Feature]: Selenium Manager support "internet-explorer" [🚀 Feature]: Selenium Manager support browserName recognized by each driver Dec 7, 2022
bonigarcia added a commit that referenced this issue Dec 13, 2022
#11420)

* [rust] Support for multiple browser names in Selenium Manager (#11352)

* [rust] Use vector of broweser name to create a shorter conditional
@bonigarcia
Copy link
Member

Completed with #11420.

@titusfortner
Copy link
Member Author

I'm still having issues with multiple browser names on my mac, so I'm reopening to track

This is mac64 built from se_mgr_browser_path branch

sl-1495:macos titusfortner$ /Users/titusfortner/code/selenium/rb/bin/macos/selenium-manager --browser iexplorer
INFO	/Users/titusfortner/.cache/selenium/IEDriverServer/win32/4.7.0/IEDriverServer
sl-1495:macos titusfortner$ /Users/titusfortner/code/selenium/rb/bin/macos/selenium-manager --browser internetexplorer
ERROR	Invalid browser/driver name
sl-1495:macos titusfortner$ /Users/titusfortner/code/selenium/rb/bin/macos/selenium-manager --browser ie
ERROR	Invalid browser/driver name
sl-1495:macos titusfortner$ /Users/titusfortner/code/selenium/rb/bin/macos/selenium-manager --browser internet-explorer
ERROR	Invalid browser/driver name

@titusfortner
Copy link
Member Author

and this was a mistake on my part, working as intended in the latest branches.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants