Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Now the logger accepts any kind of type that can be converted to string #11865

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

dev-ardi
Copy link
Contributor

@dev-ardi dev-ardi commented Apr 5, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Now the logger accepts any kind of type that can be converted to string

Motivation and Context

Enable fix of #11810 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dev-ardi dev-ardi marked this pull request as ready for review April 5, 2023 12:41
@dev-ardi dev-ardi changed the title Now the logger accepts any kind of type that can be converted to string [rust] Now the logger accepts any kind of type that can be converted to string Apr 5, 2023
@diemol diemol requested a review from bonigarcia April 5, 2023 13:01
Copy link
Member

@bonigarcia bonigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are compilation errors. Also, please verify that all tests pass with the new changes (cargo test).

@dev-ardi
Copy link
Contributor Author

@bonigarcia I'm sorry for the really long wait! I have merged and it should work now.

Copy link
Member

@bonigarcia bonigarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot, @dev-ardi!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing, @bonigarcia!

Thank you, @dev-ardi!

@diemol diemol merged commit 7014c3e into SeleniumHQ:trunk Apr 17, 2023
9 checks passed
@dev-ardi dev-ardi deleted the refactor-logger branch April 19, 2023 11:20
@titusfortner
Copy link
Member

This commit broke the --proxy parameter. It currently ignores the proxy passed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants