[rust] Fix proxy setup in Selenium Manager (fix #12104) #12108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the issue? I think I messed up when merging |
This change broke the proxy support. The current PR should fix it. |
diemol
reviewed
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the proxy setup in Selenium Manager, broken as of #11865. Also, this PR contains a negative test for proxy setup.
UPDATE: I discovered the existing proxy test based on mockserver was actually not working, so I dropped that test in this PR. To test manually the proxy support, I used mitmproxy locally, but I haven't found a manner to implement an automated test about it.
Motivation and Context
This PR fixes #12104.
Types of changes
Checklist