-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Remove deprecated code in driver classes #12030
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12030 +/- ##
==========================================
- Coverage 55.93% 55.69% -0.25%
==========================================
Files 86 86
Lines 5746 5421 -325
Branches 233 223 -10
==========================================
- Hits 3214 3019 -195
+ Misses 2299 2179 -120
+ Partials 233 223 -10
☔ View full report in Codecov by Sentry. |
cc7cf9e
to
16c16a6
Compare
3734122
to
42a19ba
Compare
Initial review and looks ok |
9a89264
to
1fce40c
Compare
I tried a few things to get the lint test passing on CI, and nothing is working. Not sure how to proceed since things are passing just fine for me locally. |
This will allow us to update Selenium. I determined the changes needed here by looking at the PR which removed the deprecated code and working backwards: SeleniumHQ/selenium#12030
Description
get_remote_connection()
is kind of a clever hack to be able to use browser specific methods in remote webdriver class. I would love if we can get a mixin or something to better support these. Regardless, what is there currently does not work for Chrome or Edge because thebrowser_name
of theChromiumRemoteConnection
isNone
._ignore_local_proxy
which is currently getting set in Options. Anyway, future PR.Motivation and Context
It's really difficult to see what is going on in Python code with deprecations everywhere
All of this has been deprecated since 4.0 or earlier.
I'm honestly not sure when to set things to self and when not to, and when to reference things as self, so this code can probably be cleaned up even more.