Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Constrain selenium version #24538

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jun 28, 2023

SUMMARY

Per the Selenium changelog, SeleniumHQ/selenium#12030 was included in 4.10.0 which removed deprecated code including the firefox_profile option we currently use.

This PR places an upper bound on the selenium version to prevent errors of the form,

...
  File "superset/utils/webdriver.py", line 147, in create
    return driver_class(**kwargs)
TypeError: __init__() got an unexpected keyword argument 'firefox_profile'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI and verified that the error was absent in 4.9.0 and present in 4.10.0.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #24538 (a6a01d3) into master (7501134) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head a6a01d3 differs from pull request most recent head ce2c426. Consider uploading reports for the commit ce2c426 to get more accurate results

@@            Coverage Diff             @@
##           master   #24538      +/-   ##
==========================================
+ Coverage   68.93%   69.07%   +0.14%     
==========================================
  Files        1903     1903              
  Lines       74027    74027              
  Branches     8118     8118              
==========================================
+ Hits        51027    51136     +109     
+ Misses      20889    20780     -109     
  Partials     2111     2111              
Flag Coverage Δ
hive 53.89% <ø> (?)
mysql 79.41% <ø> (ø)
postgres 79.50% <ø> (ø)
presto 53.79% <ø> (?)
python 83.48% <ø> (+0.30%) ⬆️
sqlite 78.00% <ø> (ø)
unit 54.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley merged commit 0986423 into master Jun 28, 2023
54 checks passed
@john-bodley john-bodley deleted the john-bodley--constrain-selenium-version branch June 28, 2023 17:52
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jun 28, 2023
@john-bodley john-bodley added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jul 10, 2023
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jul 11, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants