-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Bumping Java deps #12528
[java] Bumping Java deps #12528
Conversation
- Adding `@SuppressWarnings({"rawtypes", "RedundantSuppression"})` to remove warning from AutoService using raw types and generics. - Setting `System.setProperty("otel.logs.exporter", "none");` to keep the open telemetry behaviour as before.
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12528 +/- ##
=======================================
Coverage 57.26% 57.26%
=======================================
Files 86 86
Lines 5335 5335
Branches 198 198
=======================================
Hits 3055 3055
Misses 2082 2082
Partials 198 198 ☔ View full report in Codecov by Sentry. |
@diemol will merging this not automatically set the minimum java version to 11? |
I thought we just changed all of the CI execution to Java 17 for bazel reasons? |
@titusfortner when? I was not aware of that. |
Thanks for pointing it out, @joerg1985. I did not read the release notes. The strange part is that it seems things build with Java 8 as a target. |
I don't understand why tests using mockito fail, they pass for me locally. |
Bazel is again swallowing the cause of the exception thrown, i think this is something that should be fixed. The logged 'IllegalStateException' is raised here and this should have a cause set: |
@diemol Looks like the mockito-inline is not needed any more, removing it from maven_deps.bzl and .../remote/BUILD.bazel does not fix the issue, but will make different tests fail with another root cause. I added this to the try/catch block in CommandLineTest.spyProcess
No i get this output:
And this seems to be this issue mockito/mockito#2436 |
Thanks for debugging, @joerg1985. I will revert the version bump and watch the issue. It is just strange that it passes for me locally. |
Are you at jdk 17 or jdk 11 locally? |
JDK 11 locally, but Bazel is using JDK 17 to run everything. However, if I run it on macOS it does not fail. On a Linux machine, it fails. |
@SuppressWarnings({"rawtypes", "RedundantSuppression"})
to remove warning from AutoService using raw types and generics.System.setProperty("otel.logs.exporter", "none");
to keep the open telemetry behaviour as before.Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Also, fixes SeleniumHQ/docker-selenium#1883
Motivation and Context
Types of changes
Checklist