Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Indicate end of output taken from selenium manager #12744

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

nvborisenko
Copy link
Member

Description

When selenium manager fails to do something, we raise output in exception. This PR improves slightly output to indicate where output starts and ends.

Motivation and Context

Improve readability of SM process output.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko nvborisenko added this to the 4.13 milestone Sep 14, 2023
@titusfortner titusfortner merged commit d1a1c02 into SeleniumHQ:trunk Sep 15, 2023
14 checks passed
@nvborisenko nvborisenko deleted the dotnet-sm-output branch September 15, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants