Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] add ability to disabled UI on grid #13212

Merged
merged 5 commits into from Dec 11, 2023

Conversation

RevealOscar
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

initial attempt to disable grid UI for #12725

Haven't figured out a way to add the necessary tests to see if what I did is valid.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebf9de9) 57.95% compared to head (6e6dae4) 57.95%.

❗ Current head 6e6dae4 differs from pull request most recent head f86f2b5. Consider uploading reports for the commit f86f2b5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13212   +/-   ##
=======================================
  Coverage   57.95%   57.95%           
=======================================
  Files          88       88           
  Lines        5333     5333           
  Branches      224      224           
=======================================
  Hits         3091     3091           
  Misses       2018     2018           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani
Copy link
Contributor

pujagani commented Dec 6, 2023

Can you please run the script ./scripts/format.sh?

@diemol diemol dismissed pujagani’s stale review December 11, 2023 12:52

Changes were applied

@diemol diemol merged commit 0720bbd into SeleniumHQ:trunk Dec 11, 2023
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants