Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Add config to control disabling Grid UI #2083

Merged
merged 1 commit into from Jan 9, 2024

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jan 8, 2024

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat(chart): Add config to control disabling Grid UI

Motivation and Context

On the upstream repo, the implementation to add the option --disable-ui has been done via SeleniumHQ/selenium#13212 - will be released in 4.17.0
Add the ENV var SE_DISABLE_UI to get the value in container start and also a config in Selenium Grid chart

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 requested a review from diemol January 8, 2024 08:40
@VietND96 VietND96 self-assigned this Jan 8, 2024
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @VietND96!

Should be merged after 4.17.0 is released, right?

@VietND96
Copy link
Member Author

VietND96 commented Jan 8, 2024

Yes, we will merge this with 4.17.0 image tag

@VietND96 VietND96 merged commit 7accd3f into SeleniumHQ:trunk Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants