-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js] until.alertIsPresent(): Workaround for GeckoDriver conversion error #2137
[js] until.alertIsPresent(): Workaround for GeckoDriver conversion error #2137
Conversation
// XXX: Workaround for GeckoDriver error `TypeError: can't convert null | ||
// to object`. For more details, see | ||
// https://github.com/SeleniumHQ/selenium/pull/2137 | ||
|| e instanceof error.WebDriverError)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for the specific error you are working around:
(e instanceof error.WebDriverError && e.message === `can't convert null to object`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Thanks for pointing it out.
Added
Please update unit_test.js |
Can you also raise a bug on bugzilla? Looks like we need to make sure the right type of exception is thrown which currently isn't being done. On 20 May 2016, 22:24 +0100, jleybanotifications@github.com, wrote:
|
Bug for GeckoDriver raised: https://bugzilla.mozilla.org/show_bug.cgi?id=1274924 |
@jleyba until_test.js updated. Should I add a note in CHANGES.md for workarounds? |
Yeah, there should probably be a mention in CHANGES
|
…er (#489) * Automate installation of new Gecko Driver * Use worked around client (see SeleniumHQ/selenium#2137) * Centralize Alert management in a Wrapper
In some occasions, Gecko driver throws an error while waiting on an alert to come (which eventually does). The error comes from this particular line.
Without the workaround, here are the logs I get:
I'm not too sure how to tackle this issue. Nonetheless, I propose this workaround in the meantime. Does that sound okay to you guys @jleyba @AutomatedTester ?
X
in the preceding checkbox, I verify that I have signed the Contributor License Agreement