Fix build for IDEA users: some dependencies had broken paths #2449
Conversation
| @@ -1,7 +1,7 @@ | |||
| <component name="libraryTable"> | |||
| <library name="jetty"> | |||
| <CLASSES> | |||
| <root url="jar://$PROJECT_DIR$/build/third_party/java/jetty/jetty-repacked.jar!/" /> | |||
| <root url="jar://$PROJECT_DIR$/third_party/java/jetty/jetty-repacked.jar!/" /> | |||
There was a problem hiding this comment.
this file also doesn't exist until you build it... the build folder one should exist for you, not sure why it doesn't
There was a problem hiding this comment.
this file also doesn't exist until you build it...
Do you mean third_party/java/jetty/jetty-repacked.jar? It does exist actually:
$ git co master && ./go clean && find . -name jetty-repacked.jar
(in /Users/alb/workspace/selenium)
./third_party/java/jetty/jetty-repacked.jar
There was a problem hiding this comment.
go clean doesn't clean everything.
git clean -xdf
There was a problem hiding this comment.
I see, but I still think that the path should point to third_party/ and not to build/third_party/
$ git clean -xdf && ./go clean && find . -name jetty-repacked.jar
-- no result whatsoever
$ ./go clean test_firefox && find . -name jetty-repacked.jar
-- still no result
$ ./go repack-jetty
$ find . -name jetty-repacked.jar
./build/third_party/java/jetty/jetty-repacked.jar
./third_party/java/jetty/jetty-repacked.jar
-- there it is!
$ ./go clean
$ find . -name jetty-repacked.jar
./third_party/java/jetty/jetty-repacked.jar
-- gone again!
Looks like you get build/third_party/java/jetty/jetty-repacked.jar right after executing go repack-jetty; but as soon as you run go clean it is lost, and all is left is third_party/java/jetty/jetty-repacked.jar.
There was a problem hiding this comment.
You shouldn't be running clean so much ;) with the switch to buck it actually doesn't make sense to do it
There was a problem hiding this comment.
I think I may even remove the 'clean' target :)
There was a problem hiding this comment.
Uhm ok then :)
I've reverted the changes for jetty.
Please check it out.
Compilation for the module client (Java) was failing on IDEA.
[X] By placing an
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement