-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for IDEA users: some dependencies had broken paths #2449
Conversation
@@ -1,7 +1,7 @@ | |||
<component name="libraryTable"> | |||
<library name="jetty"> | |||
<CLASSES> | |||
<root url="jar://$PROJECT_DIR$/build/third_party/java/jetty/jetty-repacked.jar!/" /> | |||
<root url="jar://$PROJECT_DIR$/third_party/java/jetty/jetty-repacked.jar!/" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file also doesn't exist until you build it... the build folder one should exist for you, not sure why it doesn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file also doesn't exist until you build it...
Do you mean third_party/java/jetty/jetty-repacked.jar
? It does exist actually:
$ git co master && ./go clean && find . -name jetty-repacked.jar
(in /Users/alb/workspace/selenium)
./third_party/java/jetty/jetty-repacked.jar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go clean doesn't clean everything.
git clean -xdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, but I still think that the path should point to third_party/
and not to build/third_party/
$ git clean -xdf && ./go clean && find . -name jetty-repacked.jar
-- no result whatsoever
$ ./go clean test_firefox && find . -name jetty-repacked.jar
-- still no result
$ ./go repack-jetty
$ find . -name jetty-repacked.jar
./build/third_party/java/jetty/jetty-repacked.jar
./third_party/java/jetty/jetty-repacked.jar
-- there it is!
$ ./go clean
$ find . -name jetty-repacked.jar
./third_party/java/jetty/jetty-repacked.jar
-- gone again!
Looks like you get build/third_party/java/jetty/jetty-repacked.jar
right after executing go repack-jetty
; but as soon as you run go clean
it is lost, and all is left is third_party/java/jetty/jetty-repacked.jar
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't be running clean so much ;) with the switch to buck it actually doesn't make sense to do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I may even remove the 'clean' target :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm ok then :)
I've reverted the changes for jetty.
Please check it out.
Compilation for the module client (Java) was failing on IDEA.
[X] By placing an
X
in the preceding checkbox, I verify that I have signed the Contributor License Agreement