Anticipated the reset of 'delayedRecorder' variable #3293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Dec 27, 2016
ghost
commented
- is detected a click on an element and the handler is saved in 'delayedRecorder' variable while checking if the click is meaningful (callIfMeaningfulEvent function).
- a DOM change event identify the 'click' as meaningful and the 'domModified' function execute the handler to record the command.
- if during this execution in the recording code itself or in an delayed code execution on the same element is fired a DOM change event, the handler stored in 'delayedRecorder' will be executed another time because the variable is still valorized. This will record a doubleClick instead of single one.
added 2 commits
December 27, 2016 16:57
1) is detected a click on an element and the handler is saved in 'delayedRecorder' variable while checking if the click is meaningful (callIfMeaningfulEvent function). 2) a DOM change event identify the 'click' as meaningful and the 'domModified' function execute the handler to record the command. 3) if during this execution in the recording code itself or in an delayed code execution on the same element is fired a DOM change event, the handler stored in 'delayedRecorder' will be executed another time because the variable is still valorized. This will record a doubleClick instead of single one.
Anticipated the reset of 'delayedecorder' variable
ghost
changed the title
Added useful log in domModified function
|
Selenium IDE development has been discontinued. No more new features and no bug fixes. From Firefox 55 onwards, Selenium IDE will no longer work [1]. The last supported version is Firefox ESR 52. Yes, we've started a project to develop a new tool that should replace Selenium IDE. Follow #4406 for the progress. Sorry this issue has not beed properly and timely addressed, and thank you for submission! [1] https://seleniumhq.wordpress.com/2017/08/09/firefox-55-and-selenium-ide/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.