Add chromedriver cast APIs to remote server #7282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
requested changes
Jun 20, 2019
There was a problem hiding this comment.
Hi @jwoolley! Thank you very much for this patch --- it'll help a lot of people. Congratulations on your first PR :)
There are a couple of minor nits (basically just moving things to places that are very new) and I'll happily land this!
java/client/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java
Outdated
Show resolved
Hide resolved
ChromeDriver APIs for interacting with cast devices can now be
invoked via calls to remote server.
Referenced ChromeDriver APIs:
https://chromium-review.googlesource.com/c/chromium/src/+/1401270
Cast/MediaRouter APIs for are Chromium-specific, but not
Chrome-specific, so they're now in the appropriate module.
|
I pushed a commit that addresses the requested changes. I wasn't sure how to resolve the request as the change link is no longer valid. |
|
Thank you for your patience during this very slow review. Merging now! Congratulations, and thank you! |
loly89
pushed a commit
to loly89/selenium
that referenced
this pull request
Aug 1, 2019
ChromiumDriver APIs for interacting with cast devices can now be invoked via calls to remote server. Referenced ChromeDriver APIs: https://chromium-review.googlesource.com/c/chromium/src/+/1401270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement