Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rexml dependency #9007

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Add rexml dependency #9007

merged 2 commits into from
Jan 13, 2021

Conversation

znz
Copy link
Contributor

@znz znz commented Dec 28, 2020

Description

Since ruby 3.0.0, rexml is a bundled gem.
So it must be depend explicitly.

Motivation and Context

https://stackoverflow.com/questions/65479863/rails-6-1-what-is-preventing-tests-from-running/65480744#65480744

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Since ruby 3.0.0, rexml is a bundled gem.
So it must be depend explicitly.
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2020

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Dec 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@titusfortner
Copy link
Member

Since Selenium 4 has removed the Firefox extension, I think the right answer for trunk is to delete the requires from firefox.rb rather than adding the dependency. I haven't had a chance to pull Ruby 3 yet to check it out, yet...

@tagliala tagliala mentioned this pull request Dec 28, 2020
8 tasks
@voxik
Copy link

voxik commented Jan 8, 2021

There are also other places with REXML:

def latest
require 'rexml/document'
net_http_start('selenium-release.storage.googleapis.com') do |http|
versions = REXML::Document.new(http.get('/').body).root.get_elements('//Contents/Key').map do |e|
e.text[/selenium-server-standalone-(\d+\.\d+\.\d+)\.jar/, 1]
end
versions.compact.map { |version| Gem::Version.new(version) }.max.version
end
end

@ioquatix
Copy link

Also have this problem, fixed it by adding gem 'rexml' to my own gemfile, but good to see it's merged here. What's the ETA on the 4.0 release?

@titusfortner
Copy link
Member

@ioquatix go ahead and use the beta. Very little will change in Ruby bindings between now and final release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants