Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃悰 Bug]: Step 5: Rebase seems to not work #1144

Closed
Dor-bl opened this issue Aug 24, 2022 · 3 comments
Closed

[馃悰 Bug]: Step 5: Rebase seems to not work #1144

Dor-bl opened this issue Aug 24, 2022 · 3 comments
Labels
bug Something isn't working needs-triaging

Comments

@Dor-bl
Copy link
Contributor

Dor-bl commented Aug 24, 2022

What happened?

on the Contributing page
while trying to execute step 5: Rebase the below code doesn't work, at least for me.
% git fetch upstream
% git rebase upstream/trunk

while using the below does work:
% git fetch origin
% git rebase origin/trunk

is it just me or others who experience this issue and need to update the docs?

Disclaimer
not so familiar with git actions, that's why I opened this issue.

What browsers and operating systems are you seeing the problem on?

Not relevant

@Dor-bl Dor-bl added bug Something isn't working needs-triaging labels Aug 24, 2022
@diemol diemol closed this as completed in 0ef0bcd Aug 29, 2022
@diemol
Copy link
Member

diemol commented Aug 29, 2022

In general upstream is whatever origin the repository has. Nowadays, origin seems to be more common. I just updated the docs.

selenium-ci added a commit that referenced this issue Aug 29, 2022
[deploy site] 0ef0bcd
@Dor-bl
Copy link
Contributor Author

Dor-bl commented Aug 29, 2022

In general upstream is whatever origin the repository has. Nowadays, origin seems to be more common. I just updated the docs.

Cool, thanks for the info @diemol!

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-triaging
Projects
None yet
Development

No branches or pull requests

2 participants