Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentioning Selenium Manager in docs #1212

Merged
merged 5 commits into from Nov 4, 2022
Merged

Conversation

diemol
Copy link
Member

@diemol diemol commented Nov 3, 2022

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Selenium 4.6 will include beta 1 of Selenium Manager, which simplifies how user can
get started into Selenium. Therefore, we have modified the sections where instructions
to configure drivers are provided to mention that Selenium Manager will take care of
setting the driver for Chrome, Edge, and Firefox.

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 631cda5
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6365215283cfde000830f3ef
😎 Deploy Preview https://deploy-preview-1212--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@diemol diemol merged commit 22bdb2b into trunk Nov 4, 2022
@diemol diemol deleted the selenium-manager-mention-docs branch November 4, 2022 14:29
selenium-ci added a commit that referenced this pull request Nov 4, 2022
* Mentioning Selenium Manager in docs

* Addressing comments

* Updating link to blog post

[deploy site] 22bdb2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants