Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task Keep browser open example added #1327

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Task Keep browser open example added #1327

merged 5 commits into from
Mar 10, 2023

Conversation

ankitkumar734ac
Copy link
Contributor

@ankitkumar734ac ankitkumar734ac commented Mar 2, 2023 •
edited
Loading

Example added.
Setting the detach parameter to true will keep the browser open after the driver process has been quit.

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 60e3216
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6408f1d3bddab40008b3f25b
😎 Deploy Preview https://deploy-preview-1327--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

harsha509
harsha509 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ankitkumar734ac !

@harsha509
Copy link
Member

hi @ankitkumar734ac ,

Could you please sign CLA to get this merged ?

Thanks,
Sri

@harsha509 harsha509 added the Pending-CLA CLA needs to be signed by Author label Mar 8, 2023
@ankitkumar734ac
Copy link
Contributor Author

hi @ankitkumar734ac ,

Could you please sign CLA to get this merged ?

Thanks,
Sri

Already Done but it still show pending

@diemol
Copy link
Member

diemol commented Mar 8, 2023

Well, this user @kumarankit00792 still needs to sign it.

titusfortner
titusfortner requested changes Mar 8, 2023
View reviewed changes
Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test method name is using Python convention not Java convention

@ankitkumar734ac
Copy link
Contributor Author

Done

@titusfortner
Copy link
Member

Would also be helpful to add the example to the docs themselves in the 4 different translation files:

https://github.com/SeleniumHQ/seleniumhq.github.io/blob/trunk/website_and_docs/content/documentation/webdriver/browsers/chrome.en.md?plain=1#L121

(and thanks for helping us with this!)

@ankitkumar734ac @titusfortner
Update examples/java/src/test/java/dev/selenium/browsers/ChromeTest.java
83c6886 
Co-authored-by: Titus Fortner <titusfortner@users.noreply.github.com>
ankitkumar734ac
ankitkumar734ac commented Mar 8, 2023
View reviewed changes
Copy link
Contributor Author

@ankitkumar734ac ankitkumar734ac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method name changed as per suggestion

@ankitkumar734ac
Copy link
Contributor Author

Would also be helpful to add the example to the docs themselves in the 4 different translation files:

https://github.com/SeleniumHQ/seleniumhq.github.io/blob/trunk/website_and_docs/content/documentation/webdriver/browsers/chrome.en.md?plain=1#L121

(and thanks for helping us with this!)

Ok will try

@ankitkumar734ac
Copy link
Contributor Author

Example added in the docs for 4 different translation files

@ankitkumar734ac ankitkumar734ac requested review from harsha509 and titusfortner and removed request for titusfortner and harsha509 March 8, 2023 20:41
@harsha509
Copy link
Member

Looks good to me!

Thank you @titusfortner for the in-detail review.

@harsha509 harsha509 removed the Pending-CLA CLA needs to be signed by Author label Mar 10, 2023
@harsha509 harsha509 merged commit f255a31 into SeleniumHQ:trunk Mar 10, 2023
selenium-ci added a commit that referenced this pull request Mar 10, 2023
@selenium-ci @ankitKumarCloudanalogy @harsha509
Task Keep browser open example added (#1327)[deploy site]
6d412b5 
* Task Keep browser open example added

* Update examples/java/src/test/java/dev/selenium/browsers/ChromeTest.java

Co-authored-by: Titus Fortner <titusfortner@users.noreply.github.com>

* rename the test method name and add the example to the docs themselves in the 4 different translation files

---------

Co-authored-by: Ankit Kumar <kumar.ankit@cloudanalogy.com>
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
Co-authored-by: Titus Fortner <titusfortner@users.noreply.github.com> f255a31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha509 harsha509 harsha509 approved these changes

@titusfortner titusfortner Awaiting requested review from titusfortner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ankitkumar734ac @CLAassistant @harsha509 @diemol @titusfortner @ankitKumarCloudanalogy