Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor updates #1406

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Various minor updates #1406

merged 5 commits into from
Jun 15, 2023

Conversation

titusfortner
Copy link
Member

Description

  • Update installation & contributing docs
  • Change the text and bold the link to the full documentation
  • Add implementation badge to indicate features that aren't available in that language yet
  • Add examples badge to indicate that hard coded examples need to be moved over to github (addresses concern in - update wait documentation #1358)
  • If using --ignoreCache it can take longer than default 30 seconds to start up

Motivation and Context

Rather than a bunch of little PRs or merging directly, here's one PR for feedback on a number of things.

The big change here is how we display the link to the code on GitHub

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit b3666d2
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/648b2eccacc69c0008423dbd
😎 Deploy Preview https://deploy-preview-1406--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@titusfortner
Copy link
Member Author

Here's a good example of the bold note about seeing full code - https://deploy-preview-1406--selenium-dev.netlify.app/documentation/webdriver/drivers/service/#default-service-instance

README.md Show resolved Hide resolved
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @titusfortner!

@diemol diemol merged commit 100eed6 into trunk Jun 15, 2023
7 checks passed
@diemol diemol deleted the random_updates branch June 15, 2023 20:32
selenium-ci added a commit that referenced this pull request Jun 15, 2023
* recommended updates

* these should not be used by default

* emphasize that there is more code to see

* create implementation badge

* create new badge to mark examples that need to be moved to the examples directory

[deploy site] 100eed6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants