Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate working with select elements to spanish #346

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Translate working with select elements to spanish #346

merged 2 commits into from
Mar 20, 2020

Conversation

jmartinezpoq
Copy link
Contributor

Description

Translate working with select elements page to spanish

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

harsha509
harsha509 approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@diemol diemol merged commit 0b46eb2 into SeleniumHQ:master Mar 20, 2020
@jmartinezpoq jmartinezpoq deleted the working_select_spanish branch March 21, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harsha509 harsha509 harsha509 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmartinezpoq @harsha509 @diemol