Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip getSemanticModule in fastboot mode #209

Merged
merged 1 commit into from Feb 13, 2018

Conversation

niranjan94
Copy link
Collaborator

@niranjan94 niranjan94 commented Dec 8, 2017

In fastboot mode, Accessing this.element is not allowed in non-interactive environments (such as FastBoot). error is thrown due to the calling of getSemanticScope (since it tries to access the jQuery element) via the getSemanticModule call present in the execute method.

Follow up to #204
Resolves #100

In fastboot mode, `Accessing `this.element` is not allowed in non-interactive environments (such as FastBoot).` error is thrown due to the calling of `getSemanticScope` (since it tries to access the jQuery element) via the `getSemanticModule` call present in the `execute` method.
@championswimmer
Copy link
Collaborator

would appreciate this getting merged !

@championswimmer
Copy link
Collaborator

@aaronbhansen

@aaronbhansen
Copy link
Contributor

I'm not maintaining this anymore, if one of you would like to be a Maintainer I'll add you as one

@niranjan94
Copy link
Collaborator Author

niranjan94 commented Feb 9, 2018 via email

@championswimmer
Copy link
Collaborator

I and @niranjan94 have worked together under @fossasia banner for some OSS projects

At my company @coding-blocks we use Ember for many projects including https://hack.codingblocks.com and https://codingblocks.online

I would like to help out in maintaining with @niranjan94 this, as I also actively use this package.

@niranjan94
Copy link
Collaborator Author

I would like to help out in maintaining with @niranjan94 this

Yep. That'd be great .. !

@niranjan94 niranjan94 merged commit 041c56e into Semantic-Org:master Feb 13, 2018
@niranjan94 niranjan94 deleted the fastboot-error-fix branch February 13, 2018 14:53
@championswimmer
Copy link
Collaborator

@aaronbhansen / @niranjan94
Could I get collaborator access ?

Also how to get about to making npm releases ? I can do that given access to the npm package.

@niranjan94
Copy link
Collaborator Author

@aaronbhansen would be able to give you collaborator access @championswimmer

And yes, we need access to publish to npm too. I don't have that yet.

@aaronbhansen
Copy link
Contributor

You should already be a collaborator. I can look at adding you to npm later today when I get time

@championswimmer
Copy link
Collaborator

@aaronbhansen
Yep got the collaborator access. Was able to work with @niranjan94 to review and merge a few changes already. Thanks !

@championswimmer
Copy link
Collaborator

@aaronbhansen
My NPM handle is championswimmer (same as my Github handle)

@aaronbhansen
Copy link
Contributor

@championswimmer you are added to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants