New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip getSemanticModule
in fastboot mode
#209
Conversation
In fastboot mode, `Accessing `this.element` is not allowed in non-interactive environments (such as FastBoot).` error is thrown due to the calling of `getSemanticScope` (since it tries to access the jQuery element) via the `getSemanticModule` call present in the `execute` method.
47472a8
to
3e41d17
Compare
would appreciate this getting merged ! |
I'm not maintaining this anymore, if one of you would like to be a Maintainer I'll add you as one |
Sure. I could help out. Since we actively use this addon in the company I
work for
…On Fri, Feb 9, 2018, 2:21 AM Aaron Hansen ***@***.***> wrote:
I'm not maintaining this anymore, if one of you would like to be a
Maintainer I'll add you as one
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#209 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACSwFOdF6GwPejarAcSBIyJXVBHPmi2mks5tS14xgaJpZM4Q7aqJ>
.
|
I and @niranjan94 have worked together under @fossasia banner for some OSS projects At my company @coding-blocks we use Ember for many projects including https://hack.codingblocks.com and https://codingblocks.online I would like to help out in maintaining with @niranjan94 this, as I also actively use this package. |
Yep. That'd be great .. ! |
@aaronbhansen / @niranjan94 Also how to get about to making npm releases ? I can do that given access to the npm package. |
@aaronbhansen would be able to give you collaborator access @championswimmer And yes, we need access to publish to npm too. I don't have that yet. |
You should already be a collaborator. I can look at adding you to npm later today when I get time |
@aaronbhansen |
@aaronbhansen |
@championswimmer you are added to npm |
In fastboot mode,
Accessing
this.elementis not allowed in non-interactive environments (such as FastBoot).
error is thrown due to the calling ofgetSemanticScope
(since it tries to access the jQuery element) via thegetSemanticModule
call present in theexecute
method.Follow up to #204
Resolves #100