Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 fastboot upgrade #204

Merged
merged 3 commits into from
Aug 17, 2017
Merged

v1 fastboot upgrade #204

merged 3 commits into from
Aug 17, 2017

Conversation

deanmraz
Copy link

@deanmraz deanmraz mentioned this pull request Aug 16, 2017
Copy link
Collaborator

@aureliosaraiva aureliosaraiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its good for me, waiting for travis to pass.

package.json Outdated
@@ -35,17 +35,20 @@
"dependencies": {
"ember-cli-babel": "6.6.0",
"ember-promise-tools": "1.0.0",
"ember-runtime-enumerable-includes-polyfill": "2.0.0",
"ember-string-ishtmlsafe-polyfill": "^1.1.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you will have to recover this, did you have to remove this addon?

Copy link
Author

@deanmraz deanmraz Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed because I got this message running ember serve locally.

ember-string-ishtmlsafe-polyfill is not required for Ember 2.8.0 and later, please remove from your `package.json`.

Seems like its necessary for backwards compatibility so I'll add it back in.

@aureliosaraiva
Copy link
Collaborator

Thank you!

@aureliosaraiva aureliosaraiva merged commit 573f46d into Semantic-Org:master Aug 17, 2017
@rizkysyazuli
Copy link

hi. just asking, when can we expect this to be available on yarn/npm?

@championswimmer
Copy link
Collaborator

Yeah, a new release on npmjs would be highly appreciated ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants