fix(TransitionablePortal): fix onClose call

Semantic-Org · Feb 15, 2022 · 1fe1aac · 1fe1aac
1 parent ff70355
commit 1fe1aac
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/addons/TransitionablePortal/TransitionablePortal.js b/src/addons/TransitionablePortal/TransitionablePortal.js
@@ -58,9 +58,17 @@ export default class TransitionablePortal extends Component {
   handleTransitionHide = (nothing, data) => {
     debug('handleTransitionHide()')
     const { portalOpen } = this.state
+    const { open } = this.props
 
     this.setState({ transitionVisible: false })
-    _.invoke(this.props, 'onClose', null, { ...data, portalOpen: false, transitionVisible: false })
+
+    if (_.isUndefined(open) || open) {
+      _.invoke(this.props, 'onClose', null, {
+        ...data,
+        portalOpen: false,
+        transitionVisible: false,
+      })
+    }
     _.invoke(this.props, 'onHide', null, { ...data, portalOpen, transitionVisible: false })
   }
 

diff --git a/test/specs/addons/TransitionablePortal/TransitionablePortal-test.js b/test/specs/addons/TransitionablePortal/TransitionablePortal-test.js
@@ -83,6 +83,17 @@ describe('TransitionablePortal', () => {
       }, done)
     })
 
+    it('is not called if portal already closed ', () => {
+      const onClose = sandbox.spy()
+
+      wrapperMount(
+        <TransitionablePortal {...requiredProps} onClose={onClose} transition={quickTransition} />,
+      )
+
+      wrapper.setProps({ open: false })
+      onClose.should.not.have.been.called()
+    })
+
     it('changes `portalOpen` to false', () => {
       wrapperMount(
         <TransitionablePortal