Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(Dropdown): multiple search dropdown should refocus the input element on select of an option #1243

Closed
apiv opened this issue Jan 28, 2017 · 2 comments

Comments

@apiv
Copy link
Contributor

apiv commented Jan 28, 2017

Steps

  1. Type search term in multiple select
  2. Click one of the results

Expected Result

The result should be added to the list, and I should be able to continue typing to search for another option.

Actual Result

The result is added to the list, but focus is taken away from the input box. In order to search for another item, I need to click back into the input. Backspacinc still works, and still removes the label from the list when pressed.

actual

Version

v0.64.4

Testcase

http://react.semantic-ui.com/modules/dropdown#multiple-search-selection

More than willing to submit a PR for this if the maintainers of this repo agree with the expected behavior above.

@levithomason
Copy link
Member

Agree! This will prove tricky given the side effects of focus and blur (opens/closes the dropdown, fires on focus, etc). These things will somehow need to be circumvented so that we aren't firing unnecessary state changes and callbacks when an item is activated.

Also, it seems this should only happen on user click of an item.

@apiv apiv changed the title Dropdown multiple search-select should refocus the input element on select of an option bug(Dropdown): multiple search dropdown should refocus the input element on select of an option Jan 30, 2017
@levithomason
Copy link
Member

Fixed in #1247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants