Tab menu option tabular is being overused for both style and position.

[ryanmcgarvey]

Steps

Given the following menu options for Tab:

const menu = {
  attached: false,
  fluid: true,
  vertical: true,
  tabular: 'right',
  secondary: true,
  borderless: true,
}

Expected Result

The tabs should be on the right, and the style should be secondary (non-tabular).

Actual Result

The tabs are on the right, but the style is tabular, ignoring the secondary configuration.

Version

0.75.1

Testcase

Example
Proposed solution
In my PR #2265 - I've added an "aligned" option, which is used to determine right or left alignment, regardless of which style configuration you've set.

[brianespinosa]

Hello, @ryanmcgarvey. Please fork and create a working test case with any new issue reports: https://codesandbox.io/s/2l3n74j9y

[ryanmcgarvey]

@brianespinosa How do I select my fork as a dependency? I've fixed the issue with pull request #2265 but don't know how to create w test case on the sandbox without pushing a new package up to npm.

[ryanmcgarvey]

@brianespinosa I created a fork on NPM, as seen here: https://codesandbox.io/s/0mm43m33xl

[brianespinosa]

@ryanmcgarvey I forked your pen here: https://codesandbox.io/s/kkklrvz9n5

The options for vertical type menus can be found here: https://semantic-ui.com/collections/menu.html#vertical-menu

In the pen I edited for you, I set your vertical menu to secondary instead of tabular. Keep in mind that for the Tab component, the menu prop is a shorthand for the Menu component itself so all available props for it can be seen in the docs I linked to above.

[ryanmcgarvey]

@brianespinosa the issue is that in order to right align the menu, tabular must be set to 'right', which then overrides the secondary option and sets the tab style.

[levithomason]

@ryanmcgarvey please fill out the complete issue template. I'm still not able to understand the issue and proposed solution. We want to help, we need the full information in order to do so effectively. Thanks in advance.

[ryanmcgarvey]

@levithomason Updated issue as per the template. Thanks for being patient guys - I consume WAY more open source software than I contribute to. Let me know if you need any more clarification.

[levithomason]

@ryanmcgarvey thanks much! I immediately understood the issue now and I also agree with your proposal.