Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0.0-beta.2] Type Tab.Pane is missing #4457

Closed
Tracked by #4409
hanazuki opened this issue Dec 31, 2023 · 2 comments · Fixed by #4473
Closed
Tracked by #4409

[v3.0.0-beta.2] Type Tab.Pane is missing #4457

hanazuki opened this issue Dec 31, 2023 · 2 comments · Fixed by #4473
Labels

Comments

@hanazuki
Copy link

Bug Report

Tab.Pane type is missing in the TypeScript type definition from v3.0.0-beta.2.

It seems the property was mistakenly dropped from Tab.d.ts in this commit: e243fa4#diff-a4fd743c7d3d12205492c1129d5fc47d15c620f7a76a38a1de0864f18e605092

Steps

Type-check the following code in TypeScript.

import { Tab } from 'semantic-ui-react'
export const App = () => <Tab panes={
  [{
    menuItem: { content: 'tab' },
    render: () => <Tab.Pane>pane</Tab.Pane>
  }]
} />

Expected Result

It's well-typed.

Actual Result

src/Test.tsx:5:24 - error TS2339: Property 'Pane' does not exist on type 'ForwardRefComponent<TabProps, HTMLDivElement>'.

5     render: () => <Tab.Pane>pane</Tab.Pane>
                         ~~~~

src/Test.tsx:5:39 - error TS2339: Property 'Pane' does not exist on type 'ForwardRefComponent<TabProps, HTMLDivElement>'.

5     render: () => <Tab.Pane>pane</Tab.Pane>
                                        ~~~~

Version

3.0.0-beta.2

Testcase

Copy link

welcome bot commented Dec 31, 2023

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

Oops. @hanazuki do you want to submit a PR to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants