Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(mixed): remove usage of meta.props #1239

Merged
merged 10 commits into from
Feb 17, 2017
Merged

tests(mixed): remove usage of meta.props #1239

merged 10 commits into from
Feb 17, 2017

Conversation

layershifter
Copy link
Member

This PR completely removes usage of meta.props from tests.

@layershifter
Copy link
Member Author

@levithomason Any ideas why tests are failed on CI?

27 01 2017 19:23:26.438:WARN [PhantomJS 2.1.1 (Linux 0.0.0)]: Disconnected (1 times), because no message in 10000 ms.

@codecov-io
Copy link

codecov-io commented Jan 30, 2017 •
edited
Loading

Codecov Report

Merging #1239 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1239   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         140      140           
  Lines        2402     2402           
=======================================
  Hits         2396     2396           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5a22e...c95831f. Read the comment docs.

@layershifter
Copy link
Member Author

I've rebased to master, but still have no idea what is going with PhantomJS.

@levithomason
Copy link
Member

I've marked this issue and will take a look soon as I can.

@layershifter
Copy link
Member Author

I'll rebase to master today, there was updates in #1273 for Popup tests

@layershifter
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
f78020b 
…React into chore/update-tests

# Conflicts:
#	test/specs/elements/List/ListContent-test.js
#	test/specs/modules/Popup/Popup-test.js
@layershifter
Copy link
Member Author

I've rebased, but, Popup's tests still fail in same place.

@levithomason
Copy link
Member

Looking...

@layershifter
Copy link
Member Author

I'm making PR for Popup, I'll try to solve problem there. However, there is simple explanation why it worked: test used _meta.props.positions while they was defined in _meta.props.positioning, so it doesn't really work.

@layershifter
Copy link
Member Author

Okay, problem is solved, need to rebase it 😄

@layershifter layershifter mentioned this pull request Feb 13, 2017
Merged
@layershifter
Copy link
Member Author

We need merge #1322 before this.

Alexander Fedyashov added 2 commits February 14, 2017 18:52
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
c1ca226 
…React into chore/update-tests

# Conflicts:
#	test/specs/modules/Popup/Popup-test.js
#	test/specs/modules/Sidebar/Sidebar-test.js
#	test/specs/views/Card/CardGroup-test.js
fix(tests): add default props
c95831f
layershifter
layershifter commented Feb 14, 2017
View reviewed changes
test/specs/commonTests.js
const { className = propKey, requiredProps = {} } = options
// required props may include a prop that creates a className
// if so, we cannot assert that it doesn't exist by default because it is required to exist
// skip assertions for required props
if (propKey in defaultProps) return
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased, but tests failed on Sidebar, it has defaultProps for direction. So, I think it's expected behaviour there.

levithomason
levithomason approved these changes Feb 17, 2017
View reviewed changes
Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, great work here! Very appreciative of you sticking to this and seeing it all the way through.

@levithomason levithomason merged commit f69fb34 into master Feb 17, 2017
@levithomason levithomason deleted the chore/update-tests branch February 17, 2017 15:49
@levithomason
Copy link
Member

Released in semantic-ui-react@0.65.0

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
@layershifter @harel
tests(mixed): remove usage of meta.props (Semantic-Org#1239)
4ef3bbd 
* tests(mixed): remove usage of `meta.props`

* tests(mixed): fix lint issues

* tests(mixed): some fixes

* fix(Grid): fix test

* fix(Button): update ButtonGroup's test

* fix(tests): add default props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levithomason levithomason levithomason approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@layershifter @codecov-io @levithomason