Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(typings): Update structure #1395

Merged
merged 7 commits into from
Mar 2, 2017
Merged

style(typings): Update structure #1395

merged 7 commits into from
Mar 2, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Feb 28, 2017

Refence: #1182.

This PR changes typings structure to correspond JS-files.

@codecov-io
Copy link

codecov-io commented Feb 28, 2017

Codecov Report

Merging #1395 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         140      140           
  Lines        2347     2347           
=======================================
  Hits         2341     2341           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7bcf4a...d7e4b4f. Read the comment docs.

@layershifter
Copy link
Member Author

@levithomason It's ready to review, however, I don't have idea how it can be really done 🐰

I've checked with import from root and some components index.d.ts with compiler, it works.

@levithomason
Copy link
Member

I don't have idea how it can be really done 🐰

Haha, yep. Let's ship it and see what happens 💥

@levithomason levithomason merged commit 6a3e447 into master Mar 2, 2017
@levithomason levithomason deleted the style/typings branch March 2, 2017 06:08
harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Mar 8, 2017
* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure
harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Mar 8, 2017
* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure

* style(typings): Update structure
@levithomason
Copy link
Member

Released in semantic-ui-react@0.67.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants