Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(callbacks): updates in typings #1446

Merged
merged 2 commits into from
Mar 12, 2017
Merged

Conversation

layershifter
Copy link
Member

Typings update for #1445.

@codecov-io
Copy link

codecov-io commented Mar 12, 2017

Codecov Report

Merging #1446 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1446   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2364     2364           
=======================================
  Hits         2358     2358           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Accordion/Accordion.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3ac58...0c4c4b5. Read the comment docs.

@@ -52,7 +52,7 @@ export default class Accordion extends Component {
* Called when a panel title is clicked.
*
* @param {SyntheticEvent} event - React's original SyntheticEvent.
* @param {index} - The index of the clicked panel.
* @param {number|array} index The index of the clicked panel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be number only, correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

@levithomason levithomason merged commit 9fb59f2 into master Mar 12, 2017
@layershifter layershifter deleted the style/update-typings-doc branch March 12, 2017 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants