Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update sinon to version 2.0.0 #1464

Merged
merged 5 commits into from
Mar 24, 2017

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

sinon just published its new version 2.0.0.

State Update 🚀
Dependency sinon
New version 2.0.0
Type devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of sinon.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 623 commits (ahead by 623, behind by 17).

  • 15a0038 Add dist file to docs
  • 108ac04 Update docs/changelog.md and set new release id in docs/_config.yml
  • 3f5c869 Add release documentation for v2.0.0
  • 02a6ff6 2.0.0
  • 224ec4f Update Changelog.txt and AUTHORS for new release
  • c748bc5 Merge pull request #1325 from lucasfcosta/callsFake-docs
  • fee959d Merge pull request #1297 from lucasfcosta/getters-setters-new-api
  • 1bda7c4 Merge pull request #1326 from lucasfcosta/remove-unused-chain-behavior
  • 70e96f5 Remove unused chain behavior
  • bdd3f82 Add docs for the new callsFake behavior
  • ad58467 Add docs for the new API get and set behaviors
  • eb7f90f Add names to previously anonymous getter and setter test functions
  • e852f4f Add restore method for stubbed property descriptors
  • 5bbfa51 Allow stubbing getters and setters for function properties
  • 278c2ce Add getters/setters stub behaviors

There are 250 commits in total. See the full diff.


✨ Try the all new Greenkeeper GitHub Integration
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.

Screencast

Try it today. Free for private repositories during beta.

@levithomason
Copy link
Member

Pending sinon-chai requires sinon 1, this PR is pending:

chaijs/sinon-chai#73

@levithomason
Copy link
Member

Also, we can remove the sinon test rig hack now as sinon 2.0 has fixed the bundler compatibility issues:

Sinon.JS v1.x as source doesn't work with AMD loaders / RequireJS / Webpack / Browserify.
This has been resolved in Sinon v2.x; Please don't report this as a bug.

🎉

@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #1464 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2371     2371           
=======================================
  Hits         2365     2365           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd65da...19f8ac0. Read the comment docs.

@layershifter
Copy link
Member

Tracking: chaijs/sinon-chai#89

@layershifter layershifter changed the title Update sinon to version 2.0.0 🚀 chore(package): update sinon to version 2.0.0 Mar 22, 2017
@layershifter
Copy link
Member

layershifter commented Mar 22, 2017

I've updated versions, seems we're ready to go 👍

@levithomason levithomason merged commit a325294 into master Mar 24, 2017
@levithomason levithomason deleted the greenkeeper-sinon-2.0.0 branch March 24, 2017 20:26
@levithomason
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants