Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): spread the user's style prop on the Modal #1492

Merged
merged 3 commits into from
Mar 25, 2017
Merged

fix(Modal): spread the user's style prop on the Modal #1492

merged 3 commits into from
Mar 25, 2017

Conversation

rajchourasia
Copy link
Contributor

Fixes #1308

@codecov-io
Copy link

codecov-io commented Mar 21, 2017 •
edited
Loading

Codecov Report

Merging #1492 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1492   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2371     2371           
=======================================
  Hits         2365     2365           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Modal/Modal.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd65da...8d2cdba. Read the comment docs.

@layershifter
Copy link
Member

@rajchourasia It will be awesome if we add test there. And we also need to add prop to typings.

layershifter
layershifter approved these changes Mar 23, 2017
View reviewed changes
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajchourasia Thanks for PR!

@levithomason
Copy link
Member

Superb, thanks much!

@levithomason levithomason merged commit aaf4836 into Semantic-Org:master Mar 25, 2017
@levithomason
Copy link
Member

Released in semantic-ui-react@0.67.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rajchourasia @codecov-io @layershifter @levithomason