fix(Dropdown): simplify typings validation for renderLabel #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
fix/dropdown-typings
branch
from
829bfdc
to
cfb32dc
Compare
layershifter
commented
Apr 12, 2017
| @@ -225,7 +225,7 @@ export interface DropdownProps { | |||
| tabIndex?: number | string; | |||
|
|
|||
| /** The text displayed in the dropdown, usually for the active item. */ | |||
| text?: string|React.ReactNode; | |||
| text?: string; | |||
There was a problem hiding this comment.
text prop can be only string.
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2381 2381
=======================================
Hits 2375 2375
Misses 6 6Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1568.
Simplifies validation for
renderLabelbecause it usesLabel's factory that can accept element, object or string (ref #1289).