Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): use https url #1598

Merged
merged 2 commits into from
Apr 18, 2017
Merged

feat(docs): use https url #1598

merged 2 commits into from
Apr 18, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Apr 18, 2017

The doc site now supports HTTPS. Many users are linking to HTTPS, however, our SPA redirects for handling soft routes are using HTTP. This means direct links to HTTPS urls are lost and the user is redirected to the default route.

This PR moves all links to the HTTPS url.

I also fixed the Direct Link copy functionality, it was only copying the slug, now it copies the href.

@codecov-io
Copy link

codecov-io commented Apr 18, 2017

Codecov Report

Merging #1598 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1598   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2396     2396           
=======================================
  Hits         2390     2390           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c397f3e...c4067b9. Read the comment docs.

@levithomason levithomason merged commit 37ff255 into master Apr 18, 2017
@levithomason levithomason deleted the docs/https branch April 18, 2017 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants