Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextArea): add focus() method #1602

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Conversation

gnowoel
Copy link
Contributor

@gnowoel gnowoel commented Apr 21, 2017

I want to focus a TextArea element with a ref, but the ref refers to a component instance rather than a DOM element. We already solved this problem for Input by adding a focus() method, which will relay the method invocation to the underlying DOM element. So, in this PR, I'd like to add the same focus() method to the TextArea component.

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #1602 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%     
==========================================
  Files         141      141              
  Lines        2396     2397       +1     
==========================================
+ Hits         2390     2391       +1     
  Misses          6        6
Impacted Files Coverage Δ
src/addons/TextArea/TextArea.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a0710...d4d8e8e. Read the comment docs.

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnowoel Thanks for PR, I've updated a test, now lint passes. LGTM 👍

@levithomason
Copy link
Member

Thanks much guys!

@gnowoel
Copy link
Contributor Author

gnowoel commented Apr 22, 2017

@layershifter Thanks much for the test update! I felt frustrated about the failed tests since they passed on localhost :)

@levithomason
Copy link
Member

Released in semantic-ui-react@0.68.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants