Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(acc): fix default prop dev warning #1613

Merged

Conversation

jonmajorc
Copy link
Contributor

fixed #1586 with the recommended change by @levithomason .

@codecov-io
Copy link

codecov-io commented Apr 24, 2017

Codecov Report

Merging #1613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1613   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2398     2398           
=======================================
  Hits         2392     2392           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e490e...702c0a4. Read the comment docs.

@levithomason levithomason changed the title refactor: fixes #1586 (Missing undefined check) fix(acc): fix default prop dev warning Apr 24, 2017
@levithomason levithomason merged commit fbca20a into Semantic-Org:master Apr 24, 2017
@levithomason
Copy link
Member

Perfect, thanks!

@jonmajorc
Copy link
Contributor Author

Thanks for Merging! This was my first open source PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-controlled props emit spurious warning when set to undefined (missing undefined check).
3 participants