fix(Progress): use floor for data-percent attribute #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Floor the data-percent attribute so Semantic UI CSS works as expected. Fixes Semantic-Org#1671
Codecov Report
@@ Coverage Diff @@
## master #1672 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 141 141
Lines 2408 2408
=======================================
Hits 2402 2402
Misses 6 6
Continue to review full report at Codecov.
|
layershifter
changed the title
layershifter
requested changes
May 12, 2017
There was a problem hiding this comment.
@patrickgaskill Thanks for PR. It will be awesome to get a test there that asserts that Math.floor was done.
layershifter
changed the title
patrickgaskill
pushed a commit
to patrickgaskill/Semantic-UI-React
that referenced
this pull request
May 12, 2017
layershifter
approved these changes
May 12, 2017
|
Superb! Thanks, folks! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floor the data-percent attribute so Semantic UI CSS works as expected.
Fixes #1671