chore(package): update chai-enzyme to version 0.7.0 #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1692 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 141 141
Lines 2412 2412
=======================================
Hits 2406 2406
Misses 6 6Continue to review full report at Codecov.
|
layershifter
changed the title
| @@ -91,22 +91,22 @@ describe('Progress', () => { | |||
| describe('data-percent', () => { | |||
| it('adds prop by default', () => { | |||
| shallow(<Progress />) | |||
| .should.have.prop('data-percent', undefined) | |||
| .should.have.data('percent') | |||
There was a problem hiding this comment.
chai-enzyme updated enzyme, now data-percent equals NaN. I simplified this assert.
|
Thanks much @layershifter ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
chai-enzyme just published its new version 0.7.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of chai-enzyme.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 6 commits .
1e0336f0.7.030d1e2fPrepare for releaseb0d35c7handle.exactly(0)(#152)74e4b16Add support for containMatchingElement (#149)cedba77Document that style assertions should not be camelCased86454ceAdded support for undefined argument (#133)See the full diff.