Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(typings): add new types #1782

Merged
merged 7 commits into from
Jul 16, 2017
Merged

style(typings): add new types #1782

merged 7 commits into from
Jul 16, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jun 19, 2017

Fixes #1289.

This PR:

@layershifter
Copy link
Member Author

@levithomason we have following validator:

export const itemShorthand = (...args) => every([
  disallow(['children']),
  PropTypes.oneOfType([
    PropTypes.array,
    PropTypes.node,
    PropTypes.object,
  ]),
])(...args)

However, I don't remember any case when itemShorthand can be an array. Can you clarify?

@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@2b906ed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1782   +/-   ##
=========================================
  Coverage          ?   99.75%           
=========================================
  Files             ?      145           
  Lines             ?     2474           
  Branches          ?        0           
=========================================
  Hits              ?     2468           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
src/collections/Message/MessageItem.js 100% <ø> (ø)
src/modules/Progress/Progress.js 100% <ø> (ø)
src/elements/List/ListItem.js 100% <ø> (ø)
src/collections/Message/MessageHeader.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b906ed...ff3b6bf. Read the comment docs.

@layershifter layershifter force-pushed the style/new-types branch 3 times, most recently from 07a3a37 to d29aec5 Compare June 22, 2017 15:45
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levithomason Ready for review, also please pay attention to the question above.

@levithomason
Copy link
Member

However, I don't remember any case when itemShorthand can be an array. Can you clarify?

I went back and checked some old issues and discussions around this. I think we can remove the array type from itemShorthand now. Give it a go and see if you run into any test failures or documentation issues and we'll go from there.

@layershifter
Copy link
Member Author

@levithomason you have already removed it in the Tab's PR 😄 So, we're ready for review there.

@levithomason levithomason merged commit 164f750 into master Jul 16, 2017
@levithomason levithomason deleted the style/new-types branch July 16, 2017 20:04
@levithomason
Copy link
Member

Released in semantic-ui-react@0.71.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants