Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(Input): remove shorthand action button class #1791

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Jun 23, 2017

Breaking Change

Dropdown actions must now explicitly define the button prop.

Before

<Input action={<Dropdown />} />

After

<Input action={<Dropdown button />} />

Fixes #1703. For more context, see #1703 (comment).

@codecov-io
Copy link

codecov-io commented Jun 23, 2017

Codecov Report

Merging #1791 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1791   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         142      142           
  Lines        2441     2441           
=======================================
  Hits         2435     2435           
  Misses          6        6
Impacted Files Coverage Δ
src/elements/Input/Input.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74884c...db2ea19. Read the comment docs.

@levithomason levithomason merged commit f7a7052 into master Jun 23, 2017
@levithomason levithomason deleted the fix/popup-button-class branch June 23, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants