fix(TextArea): compute height when hidden #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/addons/TextArea/TextArea.js
Outdated
| return ( | ||
| <ElementType | ||
| {...rest} | ||
| onChange={this.handleChange} | ||
| ref={this.handleRef} | ||
| rows={rows} | ||
| style={{ ...style, minHeight }} | ||
| style={{ resize, height, ...style }} |
There was a problem hiding this comment.
Can we sort resize and height in alphabetical order? 😄
There was a problem hiding this comment.
Sorted all keys in objects and force pushed 👍
levithomason
force-pushed
the
fix/textarea-autoheight
branch
from
30668d8
to
7bc5f0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 144 144
Lines 2465 2465
=======================================
Hits 2459 2459
Misses 6 6
Continue to review full report at Codecov.
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1405
This PR changes the height calculation do not depend on a visible DOM node. We simply total up the box model height and text height rather than using the
scrollHeight.