Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dimmer|Modal): fix compatibility with IE #1861

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Conversation

layershifter
Copy link
Member

Fixes #1759.

IE doesn't support second arguments on add and remove.

@codecov-io
Copy link

codecov-io commented Jul 13, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@2b906ed). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1861   +/-   ##
=========================================
  Coverage          ?   99.75%           
=========================================
  Files             ?      145           
  Lines             ?     2482           
  Branches          ?        0           
=========================================
  Hits              ?     2476           
  Misses            ?        6           
  Partials          ?        0
Impacted Files Coverage Δ
src/modules/Modal/Modal.js 100% <100%> (ø)
src/modules/Dimmer/Dimmer.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b906ed...09d228b. Read the comment docs.

@levithomason levithomason merged commit 6eec9ce into master Jul 16, 2017
@levithomason levithomason deleted the fix/modal-ie branch July 16, 2017 21:34
@levithomason
Copy link
Member

Fantastic, thank you!

@levithomason
Copy link
Member

Released in semantic-ui-react@0.71.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants