chore(package): update all dependencies #1895

layershifter · 2017-07-24T14:04:49Z

WIP

This PR:

updates all deps to their latest version
removes usage of eslint-config-ta, vanilla airbnb config will be used
removes del, we have already rimraf for such cases
removes empty, cruft

TODO

fix lint errors
ES-ify configs
clean up eslint configs
merge style(docs): update formatting of Menu and Table examples #1938
merge style(tests): mixed lint updates #1939
merge style(mixed): update components styling #1949
replace babel-plugin-react-transform, it's deprecated (chore(package): switch to react-hot-loader #1946)
replace babel-plugin-__coverage__, it's deprecated (chore(package): replace deprecated babel-plugin-__coverage__ #1940)

levithomason · 2017-07-28T16:38:24Z

While we're at this, I've been testing out prettier in other projects and making some suggestions over there as well. I'm curious what our codebase looks like with it. I know it would be a drastic change in many ways, but it is one less thing to have to manage.

(cherry picked from commit 7099567) # Conflicts: # src/addons/TextArea/TextArea.js # src/modules/Popup/Popup.js

codecov-io · 2017-08-07T09:35:18Z

Codecov Report

Merging #1895 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1895   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         148     148           
  Lines        2568    2568           
======================================
  Hits         2563    2563           
  Misses          5       5

Impacted Files	Coverage Δ
src/modules/Search/Search.js	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4780cd...92de711. Read the comment docs.

layershifter · 2017-08-10T08:32:58Z

@levithomason I've splitted only style changes to separate PRs (#1938, #1939, #1949), after they will be merged I'll continue work. Please merge them, because they will cause merge conflicts.

I investigated situation with karma-webpack-with-fast-source-maps and there are no alternatives to it. In fact karma-webpack should do same, but it doesn't. However, karma-webpack-with-fast-source-maps doesn't support webpack@3 and its author doesn't plan to add it. I will check this in separate PR, possible I can simply update peerDependency in its package.json.

Also, sinon@3 was released, but packages that dependens on it aren't updated yet.

levithomason · 2017-08-13T17:27:50Z

All blocking PRs are merged.

…React into chore/update-deps # Conflicts: # docs/app/Layouts/LoginLayout.js # package.json

layershifter · 2017-08-15T15:25:12Z

Good news, karma-webpack-with-fast-source-maps was updated to support webpack@3 and sinon's deps also support 3.x 👍

I need to cleanup eslint configs and review changes.

layershifter · 2017-08-16T13:29:25Z

webpack.config.babel.js

 const { paths } = config
-const { __DEV__, __STAGING__, __TEST__, __PROD__ } = config.compiler_globals
+const { __DEV__, __TEST__, __PROD__ } = config.compiler_globals


__STAGING__ is cruft

layershifter · 2017-08-16T13:30:04Z

test/specs/modules/Checkbox/Checkbox-test.js

@@ -59,8 +58,7 @@ describe('Checkbox', () => {
  describe('indeterminate', () => {
    it('can be indeterminate', () => {
      const wrapper = mount(<Checkbox indeterminate />)
-
-      const checkboxNode = findDOMNode(wrapper.instance())
+      const checkboxNode = wrapper.getDOMNode()


Enzyme has a getDOMNode, so findDOMNode is useless there

layershifter

We're are ready for review there

levithomason · 2017-08-20T17:12:12Z

This is ready to merge, we'll have quite a few conflicts on other branches I'm sure 😕 Onward!

levithomason · 2017-08-20T20:58:37Z

Released in semantic-ui-react@0.71.5

layershifter force-pushed the chore/update-deps branch from 06558de to a942297 Compare July 24, 2017 14:04

chore(package): update all dependencies

7099567

layershifter force-pushed the chore/update-deps branch from a942297 to 7099567 Compare July 25, 2017 09:58

Alexander Fedyashov added 3 commits August 7, 2017 10:49

chore(package): update all dependencies

b051593

(cherry picked from commit 7099567) # Conflicts: # src/addons/TextArea/TextArea.js # src/modules/Popup/Popup.js

style(mixed): fix lint issues

c49ab18

chore(package): update deps, add es6 support to configs

556905f

layershifter added the blocked label Aug 7, 2017

layershifter mentioned this pull request Aug 7, 2017

style(docs): update formatting of Menu and Table examples #1938

Merged

style(docs): revert Table and Menu changes, splitted to #1938

0709c6c

layershifter mentioned this pull request Aug 7, 2017

style(tests): mixed lint updates #1939

Merged

style(docs): revert tests changes, splitted to #1939

fe163f2

This was referenced Aug 7, 2017

chore(package): replace deprecated babel-plugin-__coverage__ #1940

Merged

chore(package): switch to react-hot-loader #1946

Merged

style(mixed): restore formatting

03d3d8d

layershifter mentioned this pull request Aug 9, 2017

style(mixed): update components styling #1949

Merged

Alexander Fedyashov added 2 commits August 9, 2017 21:36

style(mixed): revert tests changes, splitted to #1949

8a05d1f

style(configs): ESify configs

606221e

levithomason added needs author feedback and removed blocked labels Aug 13, 2017

Alexander Fedyashov added 3 commits August 15, 2017 17:35

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…

6bbe4db

…React into chore/update-deps # Conflicts: # docs/app/Layouts/LoginLayout.js # package.json

chore(package): update deps

136c931

style(mixed): fix lint issues

65b8da1

style(eslint): cleanup configs

4600df7

layershifter force-pushed the chore/update-deps branch from 7c52385 to 5840486 Compare August 16, 2017 13:28

layershifter commented Aug 16, 2017

View reviewed changes

fix(configs): fix import of webpack config

43559ed

layershifter force-pushed the chore/update-deps branch from 5840486 to 43559ed Compare August 16, 2017 13:36

layershifter added ready for review and removed needs author feedback labels Aug 16, 2017

layershifter commented Aug 16, 2017

View reviewed changes

chore(package): update package-lock.json

92de711

levithomason merged commit ff5888f into master Aug 20, 2017

levithomason deleted the chore/update-deps branch August 20, 2017 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(package): update all dependencies #1895

chore(package): update all dependencies #1895

layershifter commented Jul 24, 2017 •

edited

Loading

levithomason commented Jul 28, 2017

codecov-io commented Aug 7, 2017 •

edited

Loading

layershifter commented Aug 10, 2017 •

edited

Loading

levithomason commented Aug 13, 2017

layershifter commented Aug 15, 2017

layershifter Aug 16, 2017

layershifter Aug 16, 2017

layershifter left a comment

levithomason commented Aug 20, 2017

levithomason commented Aug 20, 2017

chore(package): update all dependencies #1895

chore(package): update all dependencies #1895

Conversation

layershifter commented Jul 24, 2017 • edited Loading

WIP

TODO

levithomason commented Jul 28, 2017

codecov-io commented Aug 7, 2017 • edited Loading

Codecov Report

layershifter commented Aug 10, 2017 • edited Loading

levithomason commented Aug 13, 2017

layershifter commented Aug 15, 2017

layershifter Aug 16, 2017

Choose a reason for hiding this comment

layershifter Aug 16, 2017

Choose a reason for hiding this comment

layershifter left a comment

Choose a reason for hiding this comment

levithomason commented Aug 20, 2017

levithomason commented Aug 20, 2017

layershifter commented Jul 24, 2017 •

edited

Loading

codecov-io commented Aug 7, 2017 •

edited

Loading

layershifter commented Aug 10, 2017 •

edited

Loading