fix(Modal): fix typo in className #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
======================================
Coverage 99.8% 99.8%
======================================
Files 148 148
Lines 2561 2561
======================================
Hits 2556 2556
Misses 5 5
Continue to review full report at Codecov.
|
|
Looking into why our tests for this were passing :) |
|
We were missing quite a bit of coverage on adding/removing classes. I've updated tests and added missing coverage. Oddly enough, fixing these tests somehow fails the Sticky tests? I may not have time today to figure out why today. |
…React into fix/modal-scrolling
|
I'm almost sure that problem is with |
|
Yep, working on fix. |
|
Heh, oh boy... Thanks! |
|
Released in |
layershifter
added a commit
that referenced
this pull request
Sep 11, 2017
* fix(Modal): fix typo in className * test(Modal): add missing body class coverage * test(Modal): restore window.innerHeight after tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the awesome codepen in #1979. It show that
scrollingclassName isn't removed frombodyafterPortal's unmount. In fact, there was a typo and this PR fixes it.Fixes #1979.