Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Image): relax wrapped propType #2043

Merged
merged 1 commit into from
Sep 11, 2017
Merged

fix(Image): relax wrapped propType #2043

merged 1 commit into from
Sep 11, 2017

Conversation

layershifter
Copy link
Member

This PR relaxes wrapped propType. It makes a sence, but it will throw warning when it will be used with Item.Image because it always passes wrapped={true}:

<Item.Image
  as='a'
  href='http://example.com'
  src={src}
  size='tiny'
/>

@codecov-io
Copy link

codecov-io commented Sep 3, 2017

Codecov Report

Merging #2043 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2043   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         148      148           
  Lines        2561     2561           
=======================================
  Hits         2555     2555           
  Misses          6        6
Impacted Files Coverage Δ
src/elements/Image/Image.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f39631...7047fbc. Read the comment docs.

@levithomason levithomason merged commit d47d249 into master Sep 11, 2017
@levithomason levithomason deleted the fix/image-wrapped branch September 11, 2017 03:40
@levithomason
Copy link
Member

Released in semantic-ui-react@0.73.0

layershifter added a commit that referenced this pull request Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants