Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(Dropdown): clean searchQuery after selection in multiple search Dropdown #2112

Merged
merged 1 commit into from
Sep 24, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 24, 2017

Fixes #1829.
Rel #1795.
Rel #2048.
Rel #2109.

<Dropdown search multiple />
Type Behaviour
Before Search query was kept after item selection
After Search query will be cleared after selection, if you want to keep previous behaviour, use controlled components and handle searchQuery manually

In #1795 we changed the behaviour of searchQuery, we don't clear it after selection in multiple search Dropdown. This PR reverts this change because:

@codecov-io
Copy link

codecov-io commented Sep 24, 2017

Codecov Report

Merging #2112 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2112   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         150      150           
  Lines        2596     2596           
=======================================
  Hits         2590     2590           
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38aede2...6563c2d. Read the comment docs.

@levithomason levithomason merged commit f250dc6 into master Sep 24, 2017
@levithomason levithomason deleted the breaking/multiple-searchdropdown branch September 24, 2017 16:27
@levithomason
Copy link
Member

Thank you sir!

@levithomason
Copy link
Member

Released in semantic-ui-react@0.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants