Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): update to react 16 #2131

Merged
merged 20 commits into from
Oct 10, 2017
Merged

chore(package): update to react 16 #2131

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5a295c6
chore(package): update to react 16
Sep 27, 2017
5f17457
Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
Oct 4, 2017
0963d71
test(Responsive): fix broken test
Oct 4, 2017
aa297a2
test(Transition): fix broken tests
Oct 4, 2017
0059e4a
chore(config): fix definition of process.env
Oct 4, 2017
bb85e26
chore(package): update chai-enzyme and enzyme
Oct 4, 2017
047ae6c
chore(package): temporialy disable satisfied
Oct 4, 2017
fa6d6a1
docs(react): use prop-types, update CDN urls
Oct 4, 2017
7ac29b2
test(Tab): fix broken tests
Oct 5, 2017
0884f59
test(Rating): fix broken tests and minor refactor
Oct 5, 2017
775bc6d
test(Checkbox): fix broken tests
Oct 5, 2017
1a6c38b
test(Accordion): fix broken tests
Oct 5, 2017
4932770
test(Search): fix broken tests
Oct 5, 2017
650ee48
test(Search): revert changes
Oct 5, 2017
58c7190
test(setup): set disableLifecycleMethods globally
Oct 5, 2017
50e4e0a
test(Sticky): fix broken tests
Oct 5, 2017
49956bc
test(Search): fix broken tests
Oct 5, 2017
fc6e0f8
test(Dropdown): fix broken tests
Oct 5, 2017
a560fdd
docs(Popup): fix broken example
Oct 5, 2017
b5cdff5
chore(package): update `react-ace`, reenable `satisfied`
layershifter Oct 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions test/specs/modules/Sticky/Sticky-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,13 @@ describe('Sticky', () => {
mockPositions({ bottomOffset: 10, height: 50 })
wrapperMount(<Sticky {...positions} context={contextEl} onStick={onStick} onUnstick={onUnStick} />)

wrapper.childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(0).childAt(1).should.have.style('position', 'fixed')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

children() now has slightly different meaning

onStick.should.have.been.calledOnce()
onStick.should.have.been.calledWithMatch(undefined, positions)

wrapper.setProps({ active: false })
scrollToTop()
wrapper.childAt(1).should.have.not.style('position')
wrapper.childAt(0).childAt(1).should.have.not.style('position')
onUnStick.should.not.have.been.called()
})
})
Expand All @@ -150,8 +150,8 @@ describe('Sticky', () => {

// Scroll after trigger
scrollAfterTrigger()
wrapper.childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(1).should.have.style('top', '12px')
wrapper.childAt(0).childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(0).childAt(1).should.have.style('top', '12px')
})

it('should stick to bottom of context', () => {
Expand All @@ -160,8 +160,8 @@ describe('Sticky', () => {
wrapperMount(<Sticky {...positions} context={contextEl} />)

scrollAfterContext()
wrapper.childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(1).should.have.style('top', '-101px')
wrapper.childAt(0).childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(0).childAt(1).should.have.style('top', '-101px')
})
})
describe('onBottom', () => {
Expand Down Expand Up @@ -243,15 +243,15 @@ describe('Sticky', () => {
wrapper.setProps({ context: mockContextEl({ bottom: 0 }) })
domEvent.scroll(window)

wrapper.childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(1).should.have.style('top', '-100px')
wrapper.childAt(0).childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(0).childAt(1).should.have.style('top', '-100px')

// Scroll a bit before the top: component should stick to screen bottom
scrollAfterTrigger()

wrapper.childAt(1).should.have.style('bottom', '30px')
wrapper.childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(1).should.not.have.style('top')
wrapper.childAt(0).childAt(1).should.have.style('bottom', '30px')
wrapper.childAt(0).childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(0).childAt(1).should.not.have.style('top')
})

it('should stop pushing when reaching top', () => {
Expand All @@ -265,8 +265,8 @@ describe('Sticky', () => {
scrollAfterTrigger()

// Component should stick again to the top
wrapper.childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(1).should.have.style('top', '10px')
wrapper.childAt(0).childAt(1).should.have.style('position', 'fixed')
wrapper.childAt(0).childAt(1).should.have.style('top', '10px')
})

it('should return true if oversized', () => {
Expand Down