fix(Form): don't prevent form submission when action='' #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 151 151
Lines 2606 2606
=======================================
Hits 2600 2600
Misses 6 6
Continue to review full report at Codecov.
|
layershifter
requested changes
Oct 5, 2017
src/collections/Form/Form.js
Outdated
| @@ -102,7 +102,7 @@ class Form extends Component { | |||
|
|
|||
| // Heads up! Third party libs can pass own data as first argument, we need to check that it has preventDefault() | |||
| // method. | |||
| if (!action) _.invoke(e, 'preventDefault') | |||
| if (action === undefined) _.invoke(e, 'preventDefault') | |||
There was a problem hiding this comment.
I think that false and null are also blocking values. Let's update condition and test assertions
There was a problem hiding this comment.
Ok sure, I was thinking false and null would be incorrectly typed here.
layershifter
approved these changes
Oct 5, 2017
|
Excellent, thanks! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the action attribute is an empty string it means to submit to the current URL which is quite useful.