Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): fix webpack.config.js #2171

Merged
merged 2 commits into from
Oct 8, 2017

Conversation

armendarabyan
Copy link
Contributor

fixing syntax error

fixing syntax error
@layershifter layershifter changed the title Update webpack.config.js docs(examples): fix webpack.config.js Oct 6, 2017
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armendarabyan thanks 👍 Let's disable comma-dangle rule in examples directory:

.eslintrc

{
  "rules": {
    "comma-dangle": 0
  }
}

Webpack 2 examples should be also updated.

@codecov-io
Copy link

Codecov Report

Merging #2171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2171   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files         151      151           
  Lines        2606     2606           
=======================================
  Hits         2600     2600           
  Misses          6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee931d2...ade56ce. Read the comment docs.

@layershifter layershifter merged commit 955ed6e into Semantic-Org:master Oct 8, 2017
@layershifter
Copy link
Member

layershifter commented Oct 8, 2017

@armendarabyan Thanks 👍

Pushed some fixes, updated deps. I plan to deprecate these configs and made new examples with webpack 3 and CRA after we will merge #2131.

@levithomason
Copy link
Member

Released in semantic-ui-react@0.75.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants