BREAKING (Sidebar): remove duration prop
#3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3336 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 170 170
Lines 2806 2806
=======================================
Hits 2803 2803
Misses 3 3
Continue to review full report at Codecov.
|
|
Friendly ping @layershifter and @levithomason, I'd be happy to get some feedback whenever you guys get some time! :) |
layershifter
approved these changes
Dec 17, 2018
There was a problem hiding this comment.
@Fabianopb sorry, I'm a little busy now. I don't want to expose this in typings now, we can do this if we will have a request for it.
LGTM, thanks 👍
layershifter
changed the title
duration propduration prop
|
No problem @layershifter, thanks for the fast response! :) |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
durationprop has been removed from theSidebarcomponent. However I've maintained a static variable in theSidebarclass to still provide the default duration of 500 ms that is used to manage the callback cycle when showing and hiding the sidebar.@layershifter, as
animationDurationis now a static prop it can actually be assigned externally (like I've done in the modified tests for this PR). If that's ok, should we add that to the type definitions? It could be done as easily as modifying theSidebartype declaration in the end ofSidebar.d.tsto something like:Cheers!
(Closes #3328)