Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search): use result.id for SearchResult key #3848

Merged
merged 2 commits into from Dec 8, 2019

Conversation

unbug
Copy link
Contributor

@unbug unbug commented Nov 26, 2019

In many cases, the title value is not unique, which leads to the SearchResult never got updated. The solution is taking a new key property or the id property as the component key.

@welcome
Copy link

welcome bot commented Nov 26, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@unbug unbug changed the title Fixed key value for SearchResult Component [HIGH] Fixed key value for SearchResult Component Nov 28, 2019
@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #3848 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3848      +/-   ##
==========================================
+ Coverage   99.83%   99.84%   +<.01%     
==========================================
  Files         172      177       +5     
  Lines        3101     3143      +42     
==========================================
+ Hits         3096     3138      +42     
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Search/Search.js 99.54% <ø> (ø) ⬆️
src/lib/createPaginationItems/suffixFactories.js 100% <0%> (ø)
src/lib/createPaginationItems/itemFactories.js 100% <0%> (ø)
...lib/createPaginationItems/createPaginationItems.js 100% <0%> (ø)
src/lib/createPaginationItems/paginationUtils.js 100% <0%> (ø)
src/lib/createPaginationItems/rangeFactories.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c4508...572a4e8. Read the comment docs.

@unbug unbug changed the title [HIGH] Fixed key value for SearchResult Component Fixed key value for SearchResult Component Dec 2, 2019
@levithomason
Copy link
Member

Thank you and happy holidays 🎄🎅!

@levithomason levithomason changed the title Fixed key value for SearchResult Component fix(Search): use result.id for SearchResult key Dec 8, 2019
@levithomason levithomason merged commit 8b46b2d into Semantic-Org:master Dec 8, 2019
@welcome
Copy link

welcome bot commented Dec 8, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants